Switch to pynvml_utils.smi for PyNVML 12
#4863
Merged
+11
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
improvement
jakirkham
force-pushed
the
use_pynvml_utils_smi
branch
from
de169b9 to
9d7db9d
Compare
jakirkham
force-pushed
the
use_pynvml_utils_smi
branch
from
9d7db9d to
e305416
Compare
rjzamora
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thanks @jakirkham !
I left some comments - I don't think cugraph should be importing smi at all. As far as I can tell, it's not actually using smi queries anywhere.
benchmarks/cugraph/standalone/bulk_sampling/bench_cugraph_training.py
Outdated
Show resolved
Hide resolved
This is also quoted or commented, which makes it unused. Given this go ahead and drop it. If the code is needed again, it is simple to grab it from history and readd it.
jakirkham
commented
Jan 13, 2025
jakirkham
commented
Jan 13, 2025
benchmarks/cugraph/standalone/bulk_sampling/trainers/pyg/trainers_pyg.py
Outdated
Show resolved
Hide resolved
…ers_pyg.py Co-authored-by: jakirkham <[email protected]>
jakirkham
commented
Jan 15, 2025
benchmarks/cugraph/standalone/bulk_sampling/bench_cugraph_training.py
Outdated
Show resolved
Hide resolved
benchmarks/cugraph/standalone/bulk_sampling/bench_cugraph_training.py
Outdated
Show resolved
Hide resolved
benchmarks/cugraph/standalone/bulk_sampling/bench_cugraph_training.py
Outdated
Show resolved
Hide resolved
jakirkham
commented
Jan 15, 2025
benchmarks/cugraph/standalone/bulk_sampling/trainers/pyg/trainers_pyg.py
Show resolved
Hide resolved
|
Thanks for the feedback! 🙏 Cleaned up the bits discussed above. Please take another look when you have a moment |
|
Sounds like we are happy with these changes. Will go ahead and merge If anything else comes up, happy to discuss |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PyNVML 12 upgrade, the
pynvmlpackage now depends onnvidia-ml-py. Howevernvidia-ml-pydoes not supply thesmisubmodule. To avoid clobbering the package, this module was moved from thepynvmlnamespace topynvml_utils. As a result theimporthere needs the same tweak.